refac: introduce consistent convention for linopy operations with subsets and supersets#572
Draft
FabianHofmann wants to merge 8 commits intomasterfrom
Draft
refac: introduce consistent convention for linopy operations with subsets and supersets#572FabianHofmann wants to merge 8 commits intomasterfrom
FabianHofmann wants to merge 8 commits intomasterfrom
Conversation
4 tasks
Add le(), ge(), eq() methods to LinearExpression and Variable classes, mirroring the pattern of add/sub/mul/div methods. These methods support the join parameter for flexible coordinate alignment when creating constraints.
Consolidate repetitive alignment handling in _add_constant and _apply_constant_op into a single _align_constant method. This eliminates code duplication and makes the alignment behavior (handling join parameter, fill_value, size-aware defaults) testable and maintainable in one place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #550 #571
Changes proposed in this Pull Request
Establish a consistent coordinate alignment when linopy objects interact with DataArrays that have subset or superset coordinates
TODO:
linopy.alignaddition/multiplication/comparison+subset/superset` + order + object typesChecklist
doc.doc/release_notes.rstof the upcoming release is included.